Refactor/fusion optimization #1104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
syl20bnr
reviewed
Jan 4, 2024
burn-fusion/Cargo.toml
Outdated
| spin = { workspace = true } | ||
| log = { workspace = true } | ||
| serde = { workspace = true } | ||
| serde_json = { workspace = true } |
There was a problem hiding this comment.
Suggested change
| serde_json = { workspace = true } | |
| serde = {workspace = true, features = ["std", "derive"]} | |
| serde_json = {workspace = true, features = ["std"]} |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #1104 +/- ##
==========================================
- Coverage 85.73% 85.59% -0.14%
==========================================
Files 511 512 +1
Lines 55825 55968 +143
==========================================
+ Hits 47860 47908 +48
- Misses 7965 8060 +95 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor the fusion operation to support saving the state of the JIT cache so that we can reduce cold start. This is also necessary if we want to combine fusion with autotune, which is planned, since the autotune cache should share the same generated ID from the dynamically created kernel.
This PR doesn't actually save anything, but it makes everything serializable and deserializable with the correct ID. The refactor consists mostly of removing
dyn Traitso that we can actually serialize things. The dynamic trait is replaced with an enum, which makes sense in this context.Also found a bug with burn-fusion when changing the device, so corrected that as well.