New default recorder #1161
Merged
New default recorder #1161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nathanielsimard
requested changes
Jan 22, 2024
| tensors. The record system in Burn gives you the possibility to serialize any type, which is very | ||
| useful for optimizers that save their state, but also for any non-standard, cutting-edge modeling | ||
| needs you may have. Additionally, the record system performs automatic precision conversion by using | ||
| Rust types, making it more reliable with fewer manual manipulations. | ||
|
|
||
| It is important to note that the `safetensors` format uses the word *safe* to distinguish itself from Pickle, which is vulnerable to Python code injection. The safety comes from a checksum mechanism that guarantees that the data suffered no corruption. On our end, the simple fact that we use Rust already ensures that no code injection is possible. To prevent any data corruption, using a recorder with Gzip compression is recommended, as it includes a checksum mechanism. | ||
| It is important to note that the `safetensors` format uses the word *safe* to distinguish itself from Pickle, which is vulnerable to Python code injection. On our end, the simple fact that we use Rust already ensures that no code injection is possible. To prevent any data corruption, using a recorder with Gzip compression is recommended, as it includes a checksum mechanism. |
There was a problem hiding this comment.
Not sure if we should include this anymore: "To prevent any data corruption, using a recorder with Gzip compression is recommended, as it includes a checksum mechanism." Maybe updating it to: "If your storage mechanism doesn't handle data corruption, you may look into recorders that include a checksum, such as Gzip."
There was a problem hiding this comment.
Ahhh good point! Will fix.
nathanielsimard
approved these changes
Jan 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
run-checks allscript has been executed.Related Issues
Closes #1151
Changes
After a bit of exploration and tests it was decided that we should revert to the
NamedMpkFileRecorder(no compression) as the default. Any type of compression adds to much overhead and detracts the user experience.DefaultFileRecorder