-
Notifications
You must be signed in to change notification settings - Fork 353
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add vision/mnist dataset #1176
Add vision/mnist dataset #1176
Conversation
- Add vision dataset module - Refactor MNISTDataset to download raw data from original source - Update guide and examples
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #1176 +/- ##
==========================================
- Coverage 85.96% 84.47% -1.50%
==========================================
Files 522 546 +24
Lines 59179 61296 +2117
==========================================
+ Hits 50876 51777 +901
- Misses 8303 9519 +1216 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I think I would add a description of the new feature flag before merging. (burn/burn/src/lib.rs
)
Done! Didn't realize we had this description. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! Thank for the enhancement.
Checklist
run-checks all
script has been executed.Related Issues/PRs
Closes #1157
Changes
At last, no more Python/HF dependency for the base
MNISTDatset
! 🙂MNISTDataset
to download raw data from original source (with a nice little progress bar when a download happens)vision