Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add vision/mnist dataset #1176

Merged
merged 6 commits into from Jan 25, 2024
Merged

Add vision/mnist dataset #1176

merged 6 commits into from Jan 25, 2024

Conversation

laggui
Copy link
Member

@laggui laggui commented Jan 25, 2024

Checklist

  • Confirmed that run-checks all script has been executed.
  • Made sure the book is up to date with changes in this PR.

Related Issues/PRs

Closes #1157

Changes

At last, no more Python/HF dependency for the base MNISTDatset! 🙂

  • Add explicit note for examples with python requirement for HF datasets
  • Add vision dataset module (optional)
  • Refactor MNISTDataset to download raw data from original source (with a nice little progress bar when a download happens)
  • Update guide and examples to point to new dataset struct in vision

Copy link

codecov bot commented Jan 25, 2024

Codecov Report

Attention: 650 lines in your changes are missing coverage. Please review.

Comparison is base (4ca3e31) 85.96% compared to head (80ff22f) 84.47%.
Report is 1 commits behind head on main.

Files Patch % Lines
burn-core/src/record/serde/de.rs 39.45% 287 Missing ⚠️
burn-dataset/src/vision/mnist.rs 0.00% 134 Missing ⚠️
burn-core/src/record/serde/ser.rs 46.66% 96 Missing ⚠️
burn-dataset/src/vision/downloader.rs 0.00% 34 Missing ⚠️
burn-import/pytorch-tests/tests/boolean/mod.rs 0.00% 27 Missing ⚠️
burn-core/src/record/serde/data.rs 79.83% 24 Missing ⚠️
burn-import/src/pytorch/recorder.rs 61.53% 15 Missing ⚠️
burn-core/src/record/serde/adapter.rs 70.00% 12 Missing ⚠️
burn-core/src/record/serde/error.rs 0.00% 10 Missing ⚠️
burn-import/src/pytorch/reader.rs 91.22% 5 Missing ⚠️
... and 2 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1176      +/-   ##
==========================================
- Coverage   85.96%   84.47%   -1.50%     
==========================================
  Files         522      546      +24     
  Lines       59179    61296    +2117     
==========================================
+ Hits        50876    51777     +901     
- Misses       8303     9519    +1216     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@nathanielsimard nathanielsimard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I think I would add a description of the new feature flag before merging. (burn/burn/src/lib.rs)

@laggui
Copy link
Member Author

laggui commented Jan 25, 2024

LGTM. I think I would add a description of the new feature flag before merging. (burn/burn/src/lib.rs)

Done! Didn't realize we had this description.

Copy link
Collaborator

@antimora antimora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Thank for the enhancement.

@nathanielsimard nathanielsimard merged commit b9bd429 into main Jan 25, 2024
14 of 15 checks passed
@nathanielsimard nathanielsimard deleted the vision/mnist-dataset branch January 25, 2024 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrate MNIST Dataset to not use Python
3 participants