-
Notifications
You must be signed in to change notification settings - Fork 353
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[backend-comparison] Burnbench CLI #1260
Conversation
aa37b92
to
68a6c8f
Compare
Regions are now created with no rectangles. Rectangles are updated at draw time.
68a6c8f
to
0b1a314
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #1260 +/- ##
==========================================
- Coverage 84.41% 84.26% -0.15%
==========================================
Files 549 553 +4
Lines 61952 62275 +323
==========================================
+ Hits 52295 52478 +183
- Misses 9657 9797 +140 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't have much comments, seems good in general!
Checklist
run-checks all
script has been executed.Related Issues/PRs
Issue #1072
Changes
Add a new binary to
backend-comparison
crate calledburnbench
.There are two mods for this CLI:
term
andtui
. The UI is a work in progress and must be enabled explicitly with thetui
feature.See the README for details about the CLI user experience. I tried to made it auto-discoverable and auto-correct as much as possible. For instance typos show the list of supported benchmarks or backends with a proposal to fix it:
I chose to repeat the arguments
--backend
and--bench
instead of using comma separated list because the code is simpler and it better leverageclap
andstrum
.I chose l
-b
shorthand for a bench and-B
for backend because the tool is about benchmarks so I believe that the natural lower case is for a bench.I'll open a different PR for the upload.
Testing
Here is two commands to quickly test: