Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
run-checks all
script has been executed.Issue
Noticed that the reported validation epoch was off by 1 in the logs. For example, if you run the mnist example without early stopping to let it run for the full 10 epochs, you will see in the artifact dir:
Notice how there is no
epoch-2
invalid/
but the epochs go up to 11.Changes
Removed the
epoch + 1
inlogger.end_epoch
call for validation.Not sure if this was incremented for historical reasons that are no longer relevant, but with this easy fix everything seems to be in order when I check the log folders.
Testing
Ran the mnist example again after and the epochs match for train and valid: