-
Notifications
You must be signed in to change notification settings - Fork 353
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor/elemwise/kernel selection + dynamic fused inplace operations and broadcasting #1359
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nathanielsimard
changed the title
Refactor/elemwise/kernel selection
Refactor/elemwise/kernel selection + dynamic fused inplace operations and broadcasting
Feb 24, 2024
louisfd
approved these changes
Feb 26, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
nathanielsimard
force-pushed
the
refactor/elemwise/kernel-selection
branch
from
February 26, 2024 23:21
8af12da
to
f5c41b7
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1359 +/- ##
==========================================
- Coverage 85.40% 85.34% -0.06%
==========================================
Files 591 591
Lines 67468 67497 +29
==========================================
- Hits 57618 57604 -14
- Misses 9850 9893 +43 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor elemwise fused kernels to use the new compilation settings to identify kernels instead of pre-compiling every possible combination and having a complex selection process. This allows support for dynamic partial in-place operations as well as avoiding the execution of broadcasting procedures in fused kernels when not necessary (a new kernel is going to be created). These are very finely grained optimizations; no real speed improvements are going to be noticeable at first, but with more aggressive fusion and a longer stream of operations fused, it will help in reducing allocated memory.