[backend-comparison] Upload benchmarks results to server #1381
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
syl20bnr
force-pushed
the
feature/benchmark-results-uploading
branch
from
9e6c65c
to
f2416e5
Compare
syl20bnr
changed the title
syl20bnr
force-pushed
the
feature/benchmark-results-uploading
branch
7 times, most recently
from
77b341a
to
a1e3c9c
Compare
Uploading is enabled with already implemented --share argument of the burnbench command line tool. The burnbench binary passes the URL of the server and the auth token to the cargo bench process using the additional arguments --sharing-url and --sharing-token respectively. The persistence module then upload the results when a --sharing-url is provided. The URL is for now hardcoded. The endpoint is production when compiling in release mode and it is localhost otherwise.
syl20bnr
force-pushed
the
feature/benchmark-results-uploading
branch
from
a1e3c9c
to
403a635
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1381 +/- ##
==========================================
+ Coverage 85.34% 85.48% +0.14%
==========================================
Files 591 594 +3
Lines 67497 68042 +545
==========================================
+ Hits 57604 58168 +564
+ Misses 9893 9874 -19 ☔ View full report in Codecov by Sentry. |
nathanielsimard
approved these changes
Mar 2, 2024
| "http://localhost:8000/benchmarks" | ||
| } else { | ||
| // production | ||
| "https://user-benchmark-server-gvtbw64teq-nn.a.run.app/benchmarks" |
There was a problem hiding this comment.
I guess this URL will change right?
There was a problem hiding this comment.
It will not change as long as we keep the same service in Cloud Run.
Anyway this is temporary we will change this to use our domain at some point.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Template
Checklist
run-checks allscript has been executed.Related Issues/PRs
#1072
Changes
Uploading is enabled with already implemented
--shareargument of theburnbenchcommand line tool.The
burnbenchbinary passes the URL of the server and the auth token to the cargo bench process using the additional arguments--sharing-urland--sharing-tokenrespectively.The persistence module then upload the results when a
--sharing-urlis provided.The URL is for now hardcoded. The endpoint is production when compiling in release mode and it is localhost otherwise.
Tests