Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Element wise min/max between a pair of tensors #1385

Merged
merged 4 commits into from Mar 1, 2024

Conversation

boondocklabs
Copy link
Contributor

@boondocklabs boondocklabs commented Feb 29, 2024

Pull Request Template

Checklist

  • Confirmed that run-checks all script has been executed.
[2024-02-29T21:16:10Z INFO  xtask::runchecks] Time elapsed for the current execution: 00:06:31
  • Made sure the book is up to date with changes in this PR.

Related Issues/PRs

#856

Changes

Adds methods min_pair() and max_pair() to numeric tensors to provide pairwise min/max between a pair of tensors.

Testing

Unit tests have been added to minmax.rs

@boondocklabs boondocklabs changed the title Tensor min max Element wise min/max between a pair of tensors Feb 29, 2024
Copy link
Collaborator

@antimora antimora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Thanks for the addition.

I have very minor text update request.

crates/burn-tensor/src/tensor/api/numeric.rs Outdated Show resolved Hide resolved
crates/burn-tensor/src/tensor/api/numeric.rs Outdated Show resolved Hide resolved
crates/burn-tensor/src/tensor/api/numeric.rs Outdated Show resolved Hide resolved
crates/burn-tensor/src/tensor/api/numeric.rs Outdated Show resolved Hide resolved
@antimora antimora requested a review from ashdtu February 29, 2024 21:27
Copy link

codecov bot commented Feb 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.56%. Comparing base (2cc39f0) to head (7040255).

❗ Current head 7040255 differs from pull request most recent head 099a8f6. Consider uploading reports for the commit 099a8f6 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1385   +/-   ##
=======================================
  Coverage   85.56%   85.56%           
=======================================
  Files         594      594           
  Lines       67997    68023   +26     
=======================================
+ Hits        58180    58206   +26     
  Misses       9817     9817           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@antimora antimora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you for adding it.

Waiting to hear from others.

Copy link
Member

@louisfd louisfd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🛩️

@louisfd louisfd merged commit 201e7f8 into tracel-ai:main Mar 1, 2024
12 checks passed
@boondocklabs boondocklabs deleted the tensor-min-max branch March 2, 2024 01:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants