-
Notifications
You must be signed in to change notification settings - Fork 353
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Element wise min/max between a pair of tensors #1385
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great! Thanks for the addition.
I have very minor text update request.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1385 +/- ##
=======================================
Coverage 85.56% 85.56%
=======================================
Files 594 594
Lines 67997 68023 +26
=======================================
+ Hits 58180 58206 +26
Misses 9817 9817 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thank you for adding it.
Waiting to hear from others.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🛩️
Pull Request Template
Checklist
run-checks all
script has been executed.Related Issues/PRs
#856
Changes
Adds methods
min_pair()
andmax_pair()
to numeric tensors to provide pairwise min/max between a pair of tensors.Testing
Unit tests have been added to
minmax.rs