-
Notifications
You must be signed in to change notification settings - Fork 354
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate reduce dim + More JIT instructions + Major wgpu reduce dim refactor #1396
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@@ -96,3 +103,15 @@ impl RangeLoop { | |||
})); | |||
} | |||
} | |||
|
|||
impl Loop { | |||
/// Registers a while loop to the given scope. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it a while loop or just a loop?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just a loop, forgot to change the comment
NaiveReduceDim migrated to gpu representation
SharedReduceDim migrated to gpu representation
Instruction set needed for SharedReduceDim was added:
-workgroup size
-local invocation id
-num workgroups
-workgroup barrier
-loop (not while because we found out it's error-prone, better loop with a break)
-shared memory
Major refactor of reduce dim so kernels are generic over the algorithm type (sum, mean, argmin, argmax). Makes it much cleaner and scalable for autotune
Fix #1175