Switched arguments in reshape_args_usize
check
#1409
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Template
Checklist
run-checks all
script has been executed.Related Issues/PRs
N/A
Changes
The call to
TensorCheck::reshape_args_usize
has the arguments passed in the wrong order.into_shape
takes takes the orginal shape as the parameter, not self.These have been switched in the impls:
impl<const D2: usize> ReshapeArgs<D2> for Shape<D2>
impl<const D2: usize> ReshapeArgs<D2> for [usize; D2]
Testing
Ran the test scripts. No errors created from my changes.