Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switched arguments in reshape_args_usize check #1409

Merged

Conversation

jackdarlison
Copy link
Contributor

Pull Request Template

Checklist

  • Confirmed that run-checks all script has been executed.
  • Made sure the book is up to date with changes in this PR.

Related Issues/PRs

N/A

Changes

The call to TensorCheck::reshape_args_usize has the arguments passed in the wrong order.

into_shape takes takes the orginal shape as the parameter, not self.

These have been switched in the impls:

  • impl<const D2: usize> ReshapeArgs<D2> for Shape<D2>
  • impl<const D2: usize> ReshapeArgs<D2> for [usize; D2]

Testing

Ran the test scripts. No errors created from my changes.

Copy link

codecov bot commented Mar 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.81%. Comparing base (4ed90a9) to head (93f3470).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1409   +/-   ##
=======================================
  Coverage   85.81%   85.81%           
=======================================
  Files         610      610           
  Lines       70417    70417           
=======================================
  Hits        60428    60428           
  Misses       9989     9989           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nathanielsimard nathanielsimard merged commit 3ff6e71 into tracel-ai:main Mar 6, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants