PyTorchFileRecord print debug option #1425
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antimora
changed the title
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1425 +/- ##
==========================================
- Coverage 85.67% 85.67% -0.01%
==========================================
Files 637 637
Lines 70286 70320 +34
==========================================
+ Hits 60219 60248 +29
- Misses 10067 10072 +5 ☔ View full report in Codecov by Sentry. |
laggui
requested changes
Mar 6, 2024
| println!("Dtype: {dtype:?}"); | ||
| println!("---"); | ||
| } | ||
| println!("End of debug information."); |
There was a problem hiding this comment.
I don't think we need to indicate the end of the debug info with a sentence. The separators should be enough, no? :)
There was a problem hiding this comment.
I removed it. It was mostly to signal there are no keys. I guess we can imply it here.
| @@ -135,6 +140,12 @@ impl LoadArgs { | |||
| self.top_level_key = Some(key.into()); | |||
| self | |||
| } | |||
|
|
|||
| /// Sets printing debug information on. | |||
| pub fn with_debug_on(mut self) -> Self { | |||
There was a problem hiding this comment.
with_debug_on sounds weird. What do you think of with_debug_info instead?
There was a problem hiding this comment.
`with_print_debug' maybe?
laggui
approved these changes
Mar 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Template
Checklist
run-checks allscript has been executed.Related Issues/PRs
Fixes #1416
Changes
.with_debug_print()to PyTorchRecorder argsTesting
Added to the unit test and checked the output: