Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate/jit/prod #1474

Merged
merged 4 commits into from Mar 15, 2024
Merged

Migrate/jit/prod #1474

merged 4 commits into from Mar 15, 2024

Conversation

louisfd
Copy link
Member

@louisfd louisfd commented Mar 14, 2024

Prod and prod_dim kernels for #1422
Fix #1461

There was also a bug in jit uniform prng with ints, which is fixed here.

Copy link
Collaborator

@antimora antimora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you.

Copy link

codecov bot commented Mar 14, 2024

Codecov Report

Attention: Patch coverage is 96.80000% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 85.82%. Comparing base (4de1272) to head (4ac3e11).

Files Patch % Lines
crates/burn-jit/src/ops/int_ops.rs 0.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1474      +/-   ##
==========================================
+ Coverage   85.79%   85.82%   +0.02%     
==========================================
  Files         647      649       +2     
  Lines       72106    72222     +116     
==========================================
+ Hits        61866    61985     +119     
+ Misses      10240    10237       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nathanielsimard nathanielsimard merged commit 41d01b8 into main Mar 15, 2024
15 checks passed
@nathanielsimard nathanielsimard deleted the migrate/jit/prod branch March 15, 2024 22:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement prod and prod_dim for WGPU backend
3 participants