Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing Debug derive for Group Norm Config #1482

Merged
merged 4 commits into from Mar 17, 2024

Conversation

Arjun31415
Copy link
Contributor

@Arjun31415 Arjun31415 commented Mar 17, 2024

Pull Request Template

Checklist

  • Confirmed that run-checks all script has been executed.
  • Made sure the book is up to date with changes in this PR.

Related Issues/PRs

I had an Issue pop up while using enums

#[derive(Debug,Clone,Serialize,Deserialize)]
pub enum NormalizationType {
    BatchNorm(BatchNormConfig),
    GroupNorm(GroupNormConfig),
}
1. `GroupNormConfig` doesn't implement `Debug`
   the trait `Debug` is not implemented for `GroupNormConfig`, which is required by `&GroupNormConfig: Debug`

So I just added the derive

Changes

Added Debug to GroupNormConfig

Testing

Describe how these changes have been tested.

@Arjun31415
Copy link
Contributor Author

I think it needs to be added to Instance and Layer norm too

Copy link

codecov bot commented Mar 17, 2024

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 85.78%. Comparing base (cf3c1ca) to head (4216f3b).

Files Patch % Lines
crates/burn-core/src/nn/norm/group.rs 0.00% 1 Missing ⚠️
crates/burn-core/src/nn/norm/instance.rs 0.00% 1 Missing ⚠️
crates/burn-core/src/nn/norm/layer.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1482   +/-   ##
=======================================
  Coverage   85.77%   85.78%           
=======================================
  Files         649      649           
  Lines       72414    72414           
=======================================
+ Hits        62116    62119    +3     
+ Misses      10298    10295    -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nathanielsimard nathanielsimard merged commit d3af29c into tracel-ai:main Mar 17, 2024
13 of 14 checks passed
@Arjun31415 Arjun31415 deleted the patch-1 branch March 17, 2024 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants