Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate/jit/interpolate #1528

Merged
merged 29 commits into from Mar 26, 2024
Merged

Migrate/jit/interpolate #1528

merged 29 commits into from Mar 26, 2024

Conversation

louisfd
Copy link
Member

@louisfd louisfd commented Mar 25, 2024

Interpolate kernels for #1422
Had to merge pool-related stuff because I needed floor and ceil. I suggest we merge pool first and then we adjust this one before merging it

Copy link

codecov bot commented Mar 25, 2024

Codecov Report

Attention: Patch coverage is 99.80020% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 86.15%. Comparing base (da5b043) to head (c348eb9).
Report is 3 commits behind head on main.

❗ Current head c348eb9 differs from pull request most recent head 157574f. Consider uploading reports for the commit 157574f to get more accurate results

Files Patch % Lines
crates/burn-jit/src/kernel/interpolate/base.rs 94.87% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1528      +/-   ##
==========================================
+ Coverage   85.99%   86.15%   +0.16%     
==========================================
  Files         668      672       +4     
  Lines       76372    77298     +926     
==========================================
+ Hits        65673    66598     +925     
- Misses      10699    10700       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@nathanielsimard nathanielsimard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some small formatting comment.

crates/burn-jit/src/kernel/interpolate/bicubic.rs Outdated Show resolved Hide resolved
@louisfd louisfd merged commit 5bac300 into main Mar 26, 2024
13 checks passed
@louisfd louisfd deleted the migrate/jit/interpolate branch March 26, 2024 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants