-
Notifications
You must be signed in to change notification settings - Fork 381
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ResNet benchmark #1534
base: main
Are you sure you want to change the base?
Add ResNet benchmark #1534
Conversation
Hmm CI failed but the failing test is unrelated to this PR /edit: looking for feedback on the benchmark implementation but let's wait until we optimize some stuff before we actually merge it. This will simply be a helpful tool to evaluate the improvements along the way and once we're satisfied with the results we can merge. |
LGTM so far, great work! |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1534 +/- ##
==========================================
+ Coverage 86.19% 86.20% +0.01%
==========================================
Files 673 674 +1
Lines 77545 77606 +61
==========================================
+ Hits 66837 66898 +61
Misses 10708 10708 ☔ View full report in Codecov by Sentry. |
This PR has been marked as stale because it has not been updated for over a month |
Related Issues/PRs
Closes #1521
Changes
Added ResNet-50 inference in backend-comparison
ResNetBenchmark
executes a forward pass on a random input w/ shape[1, 3, 224, 224]
Note: doesn't include autodiff but could be added if required, similar to the current gelu benchmark
Testing
Ran the benchmark with multiple backends
Note: it doesn't run on candle because
AdaptiveAvgPool2d
in the model uses padding which is not supported.