Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conv Transpose: migration + decent speedup #1541

Merged
merged 7 commits into from Mar 28, 2024
Merged

Conversation

louisfd
Copy link
Member

@louisfd louisfd commented Mar 27, 2024

Conv transpose 2d kernel for #1422

It was the last of the kernel i had to migrate, so
Fix #1422

Also I spent a bit more time on this kernel because it was notoriously slow.
I sped it up by a factor that scales (not linearly, maybe square root or something) with the kernel size.
Benchmark for conv transpose is added as well.
For instance on my machine, with 8x8 kernel, time decreased from 524ms to 44ms.

Copy link

codecov bot commented Mar 27, 2024

Codecov Report

Attention: Patch coverage is 99.70149% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 86.35%. Comparing base (5bac300) to head (186dd66).
Report is 8 commits behind head on main.

Files Patch % Lines
...rates/burn-jit/src/kernel/conv/conv_transpose2d.rs 99.70% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1541      +/-   ##
==========================================
+ Coverage   86.19%   86.35%   +0.16%     
==========================================
  Files         673      682       +9     
  Lines       77545    78151     +606     
==========================================
+ Hits        66837    67486     +649     
+ Misses      10708    10665      -43     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@louisfd louisfd merged commit 279be04 into main Mar 28, 2024
15 checks passed
@louisfd louisfd deleted the migrate/jit/conv2d_transpose branch March 28, 2024 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrate all WGSL templates to JIT GPU representation
2 participants