Fix pytorch recorder adapt_linear when using autodiff backend #1576
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stumbled upon this issue when trying to load a record with
PyTorchFileRecorder
for a model using the autodiff backend.Checklist
run-checks all
script has been executed.Changes
The line below would panic with
Can't convert a non leaf tensor into a tracked tensor
when using the autodiff backend.That's simply because the parameter is being created from a tensor that is being transposed, an operation that is tracked by autodiff.
Solution: set require grad to false when creating the parameter from the tensor transpose.
Testing
Added autodiff unit test for complex model that includes a linear layer.