Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support linear 1d #1682

Merged
merged 1 commit into from Apr 22, 2024
Merged

Support linear 1d #1682

merged 1 commit into from Apr 22, 2024

Conversation

nathanielsimard
Copy link
Member

Fix #1672

Copy link

codecov bot commented Apr 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.42%. Comparing base (6c70852) to head (40aef2c).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1682   +/-   ##
=======================================
  Coverage   86.41%   86.42%           
=======================================
  Files         694      694           
  Lines       80676    80697   +21     
=======================================
+ Hits        69718    69739   +21     
  Misses      10958    10958           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@antimora antimora requested review from louisfd and laggui April 22, 2024 17:05
Copy link
Member

@laggui laggui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Easy fix 😄

LGTM!

Copy link
Collaborator

@antimora antimora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nathanielsimard nathanielsimard merged commit 29fa2ee into main Apr 22, 2024
15 checks passed
@nathanielsimard nathanielsimard deleted the fix/linear-1d branch April 22, 2024 22:39
syl20bnr pushed a commit that referenced this pull request Apr 26, 2024
syl20bnr pushed a commit that referenced this pull request Apr 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support forward without a batch dimension
3 participants