Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix select assign backward #1739

Merged
merged 3 commits into from
May 7, 2024
Merged

Fix select assign backward #1739

merged 3 commits into from
May 7, 2024

Conversation

nathanielsimard
Copy link
Member

The select assign backward wasn't right for the RHS

Fix #1727

Copy link

codecov bot commented May 6, 2024

Codecov Report

Attention: Patch coverage is 85.18519% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 86.55%. Comparing base (0b919b6) to head (d97bb90).
Report is 6 commits behind head on main.

Files Patch % Lines
crates/burn-tch/src/ops/base.rs 0.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1739      +/-   ##
==========================================
+ Coverage   86.47%   86.55%   +0.07%     
==========================================
  Files         698      699       +1     
  Lines       82880    83223     +343     
==========================================
+ Hits        71673    72031     +358     
+ Misses      11207    11192      -15     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@louisfd louisfd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change for lhs is actually good, my request is about the lhs. Good job

crates/burn-autodiff/src/ops/tensor.rs Outdated Show resolved Hide resolved
crates/burn-autodiff/src/ops/tensor.rs Outdated Show resolved Hide resolved
crates/burn-autodiff/src/ops/tensor.rs Outdated Show resolved Hide resolved
Copy link
Member

@louisfd louisfd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nathanielsimard nathanielsimard merged commit a6e3b4e into main May 7, 2024
15 checks passed
@nathanielsimard nathanielsimard deleted the fix/autodiff/assign branch May 7, 2024 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

.select_assign does not work with Autodiff<NdArray> backend
2 participants