Jit backend: Fix PRNG bug during autotune #1791
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1791 +/- ##
=======================================
Coverage 86.39% 86.40%
=======================================
Files 737 737
Lines 85883 85891 +8
=======================================
+ Hits 74202 74210 +8
Misses 11681 11681 ☔ View full report in Codecov by Sentry. |
nathanielsimard
approved these changes
May 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During the element types refactor of #1693 some types in PRNG that really needed to be Float were accidentally replaced with the input's element type. This could cause a type mismatch in the PRNG kernel, which could happen during autotune of int/bool tensors, which call uniform distribution PRNG.
Fix #1790