Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

define generics in doc comment for type Wgpu #1804

Closed
wants to merge 3 commits into from

Conversation

bionicles
Copy link

I didn't know what these meant, others will likely face a similar question, this can save some others some hunting around and make it more intuitive to work with wgpu

Pull Request Template

Checklist

  • Confirmed that run-checks all script has been executed.
  • Made sure the book is up to date with changes in this PR.

Related Issues/PRs

Provide links to relevant issues and dependent PRs.

Changes

Summarize the problem being addressed and your solution.

Testing

Describe how these changes have been tested.

I didn't know what these meant, others will likely face a similar question, this can save some others some hunting around and make  it more intuitive to work with wgpu
Copy link
Member

@nathanielsimard nathanielsimard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The documentation is duplicated for now when fusion is enabled, could you also add those comments on top declaration when fusion isn't enabled?

Thanks

Copy link

codecov bot commented May 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.07%. Comparing base (8bf1cd6) to head (ea1ffc3).
Report is 75 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1804   +/-   ##
=======================================
  Coverage   86.07%   86.07%           
=======================================
  Files         781      781           
  Lines       91616    91616           
=======================================
  Hits        78861    78861           
  Misses      12755    12755           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bionicles
Copy link
Author

hmm, i'm not sure what you mean by fusion, could you please post a picture of what you're talking about so i can try to reproduce that? @nathanielsimard

@nathanielsimard
Copy link
Member

image
@bionicles

The are two different pub type Wgpu with different feature flags.

@bionicles
Copy link
Author

@nathanielsimard hey, i'm sorry that brief fix took so long, I was working on other things and this fell to the 2nd page of github notifications. GitHub Workspaces enabled me to go to the patch i made before and fix what you wanted, so please let me know if that's good, just a minor doc comments improvement and your feedback was on point

Copy link
Contributor

This PR has been marked as stale because it has not been updated for over a month

@github-actions github-actions bot added the stale The issue or pr has been open for too long label Jul 16, 2024
@nathanielsimard
Copy link
Member

The generic arguments are gone, so the comments would not be very useful 😅

@bionicles
Copy link
Author

no problemo, thanks for informing me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale The issue or pr has been open for too long
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants