-
Notifications
You must be signed in to change notification settings - Fork 392
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
define generics in doc comment for type Wgpu #1804
Conversation
I didn't know what these meant, others will likely face a similar question, this can save some others some hunting around and make it more intuitive to work with wgpu
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The documentation is duplicated for now when fusion is enabled, could you also add those comments on top declaration when fusion isn't enabled?
Thanks
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1804 +/- ##
=======================================
Coverage 86.07% 86.07%
=======================================
Files 781 781
Lines 91616 91616
=======================================
Hits 78861 78861
Misses 12755 12755 ☔ View full report in Codecov by Sentry. |
hmm, i'm not sure what you mean by fusion, could you please post a picture of what you're talking about so i can try to reproduce that? @nathanielsimard |
The are two different |
@nathanielsimard hey, i'm sorry that brief fix took so long, I was working on other things and this fell to the 2nd page of github notifications. GitHub Workspaces enabled me to go to the patch i made before and fix what you wanted, so please let me know if that's good, just a minor doc comments improvement and your feedback was on point |
This PR has been marked as stale because it has not been updated for over a month |
The generic arguments are gone, so the comments would not be very useful 😅 |
no problemo, thanks for informing me |
I didn't know what these meant, others will likely face a similar question, this can save some others some hunting around and make it more intuitive to work with wgpu
Pull Request Template
Checklist
run-checks all
script has been executed.Related Issues/PRs
Provide links to relevant issues and dependent PRs.
Changes
Summarize the problem being addressed and your solution.
Testing
Describe how these changes have been tested.