-
Notifications
You must be signed in to change notification settings - Fork 364
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement Element
for bool
#1878
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1878 +/- ##
==========================================
- Coverage 86.14% 86.02% -0.12%
==========================================
Files 778 779 +1
Lines 90827 91064 +237
==========================================
+ Hits 78245 78342 +97
- Misses 12582 12722 +140 ☔ View full report in Codecov by Sentry. |
@nathanielsimard Removed |
Not sure why clippy failed on that commit specifically, seems unrelated. /edit: just saw PR #1886 fixes that |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Will this fix #1535? |
The ops won't be implemented in this PR but with these changes they could be refactored properly. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, however I would add num_trait to the NOTICE.md file before merging.
Checklist
run-checks all
script has been executed.Related Issues/PRs
Required for #1535 and
Data
refactorChanges
Since the traits
Zero
,One
andToPrimitive
fromnum-traits
could not be implemented forbool
:Added newRemoved the traits (previously kept for historical reasons)Zero
andOne
element identities (withoutAdd
andMul
requirement)ToElement
trait (adapted fromnum_traits::ToPrimitive
)Element
is now implemented forbool
, which should simplify a couple of things.