Refactor the tuner to be used standalone #1884
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1884 +/- ##
=======================================
Coverage 86.14% 86.14%
=======================================
Files 778 778
Lines 90786 90827 +41
=======================================
+ Hits 78205 78245 +40
- Misses 12581 12582 +1 ☔ View full report in Codecov by Sentry. |
louisfd
approved these changes
Jun 13, 2024
| @@ -20,14 +20,15 @@ pub type DummyClient = ComputeClient<DummyServer, DummyChannel>; | |||
|
|
|||
| static RUNTIME: ComputeRuntime<DummyDevice, DummyServer, DummyChannel> = ComputeRuntime::new(); | |||
| pub static TUNER_DEVICE_ID: &str = "tests/dummy-device"; | |||
| pub static TUNER_PREFIX: &str = "dymmy-tests/dummy-device"; | |||
|
|
||
| pub fn init_client() -> ComputeClient<DummyServer, MutexComputeChannel<DummyServer>> { | ||
| let storage = BytesStorage::default(); | ||
| let memory_management = | ||
| SimpleMemoryManagement::new(storage, DeallocStrategy::Never, SliceStrategy::Never); | ||
| let server = DummyServer::new(memory_management); | ||
| let channel = MutexComputeChannel::new(server); | ||
| let tuner = Arc::new(RwLock::new(Tuner::new(TUNER_DEVICE_ID))); | ||
| let tuner = Arc::new(RwLock::new(Tuner::new("dymmy", TUNER_DEVICE_ID))); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change how the generic arguments are passed as well as creating a name for the tuner.