Feat/fixed chunk alloc by class #1960
Open
+149
−24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1960 +/- ##
==========================================
+ Coverage 84.87% 85.14% +0.27%
==========================================
Files 797 810 +13
Lines 95082 99853 +4771
==========================================
+ Hits 80697 85022 +4325
- Misses 14385 14831 +446 ☔ View full report in Codecov by Sentry. |
nathanielsimard
requested changes
Jul 2, 2024
Comment on lines
221
to
225
| //if self.recently_allocated_size > (0.8 * self.max_chunk_size as f64) as usize { | ||
| // self.extend_max_memory(storage); | ||
| // self.recently_added_chunks = Vec::new(); | ||
| // self.recently_allocated_size = 0; | ||
| //} |
| @@ -371,6 +397,7 @@ impl MemoryPool { | |||
| ) -> ChunkHandle { | |||
| let padding = calculate_padding(size); | |||
| let effective_size = size + padding; | |||
| //let effective_size = self.max_chunk_size; | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Template
Checklist
run-checks allscript has been executed.Related Issues/PRs
Provide links to relevant issues and dependent PRs.
#1752
Changes
Added sizes classes in memory management. If an allocation is asked for that is under the class threshold, that class threshold will be allocated. This is so that when we alloc bigger and bigger slices, we are stilll able to reuse. I.E if I ask 128mb, 150mb then 170mb, I'm still able to reuse allocations without having to realloc. Also recoded extend max memory to work. It's not currently being used due to computation being slow after being used. However it was tested for correctness.
Summarize the problem being addressed and your solution.
Testing
Tested against simple mm on Text-classification ag-news-training on release mode and saw 60% speedup improvement