Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix CI workflows #275

Closed
wants to merge 3 commits into from
Closed

Fix CI workflows #275

wants to merge 3 commits into from

Conversation

antimora
Copy link
Collaborator

@antimora antimora commented Apr 6, 2023 •
edited
Loading

  1. workflows to point to templates from HEAD (Fixes CI tasks should point to head template #266)
  2. Update workflows to use dtolnay/rust-toolchain (Fixes Need to upgrade CI actions soon: Node.js 12 actions are deprecated #263)

@antimora antimora marked this pull request as draft April 6, 2023 22:43
nathanielsimard
nathanielsimard reviewed Apr 6, 2023
View reviewed changes
Copy link
Member

@nathanielsimard nathanielsimard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems OK, but are the tests working?

@antimora
Copy link
Collaborator Author

antimora commented Apr 6, 2023

It seems OK, but are the tests working?

Pointing to the local file isn't working. According to this: https://docs.github.com/en/actions/using-workflows/reusing-workflows#calling-a-reusable-workflow we should be able to specify local files. I am trying to fix it.

@antimora
Copy link
Collaborator Author

antimora commented Apr 7, 2023

Closing this because I could not get the local template to be used instead of repo/file@main format.

@antimora antimora closed this Apr 7, 2023
@antimora antimora deleted the ci-fix branch May 4, 2023 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nathanielsimard nathanielsimard nathanielsimard left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CI tasks should point to head template Need to upgrade CI actions soon: Node.js 12 actions are deprecated
2 participants
@antimora @nathanielsimard