Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/early stopping + burn train refactor #878

Merged
merged 10 commits into from
Oct 20, 2023
Merged

Conversation

nathanielsimard
Copy link
Member

@nathanielsimard nathanielsimard commented Oct 18, 2023

Another big refactor, removing the messy event collector and introduce an event store and an event processor.

Fix #841

@nathanielsimard nathanielsimard changed the title Feat/early stopping Feat/early stopping + burn train refactor Oct 18, 2023
Copy link
Member

@louisfd louisfd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This refactor is really becoming legendary! I feel we gain in both cleanness and flexibility.
I have some comments concerning the StoppingCriterion part, the rest LGTM

burn-train/src/learner/early_stopping.rs Outdated Show resolved Hide resolved
burn-train/src/learner/early_stopping.rs Outdated Show resolved Hide resolved
burn-train/src/learner/early_stopping.rs Outdated Show resolved Hide resolved
burn-train/src/learner/early_stopping.rs Outdated Show resolved Hide resolved
@nathanielsimard nathanielsimard merged commit af813d0 into main Oct 20, 2023
6 checks passed
@nathanielsimard nathanielsimard deleted the feat/early-stopping branch October 20, 2023 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Early stopping
2 participants