Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-enable Pinecone tests #57

Closed
nirga opened this issue Feb 13, 2024 · 2 comments · Fixed by #252
Closed

Re-enable Pinecone tests #57

nirga opened this issue Feb 13, 2024 · 2 comments · Fixed by #252
Labels
good first issue Good for newcomers help wanted Extra attention is needed testing

Comments

@nirga
Copy link
Member

nirga commented Feb 13, 2024

Following #56, we switched to mocked tests based on pre-recording of HTTP calls.
While this method worked well for OpenAI and other HTTP calls, I had some issues with the way our Pinecone tests are built.
This needs to be fixed and re-enabled.
@nirga nirga added good first issue Good for newcomers help wanted Extra attention is needed testing labels Feb 13, 2024
@nirga nirga changed the title Re-enabled Pinecone tests Re-enable Pinecone tests Feb 13, 2024
@detunjiSamuel
Copy link
Contributor

Hey, I am new here. I would love to work on this issue.

@nirga
Copy link
Member Author

nirga commented May 7, 2024

Yes please! @detunjiSamuel :)
You can look at other tests that we have for inspiration and I'm available on slack

@detunjiSamuel detunjiSamuel mentioned this issue May 8, 2024
Merged
@nirga nirga closed this as completed in #252 May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers help wanted Extra attention is needed testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore(pinecone): Re-enable pinecone test detunjiSamuel/openllmetry-js
2 participants
@nirga @detunjiSamuel