Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: switched to mocked tests #56

Merged
merged 7 commits into from
Feb 13, 2024
Merged

chore: switched to mocked tests #56

merged 7 commits into from
Feb 13, 2024

Conversation

nirga
Copy link
Member

@nirga nirga commented Feb 12, 2024

  • Langchain
  • LlamaIndex
  • Bedrock
  • VertexAI
  • Pinecone

@nirga nirga assigned nirga and galkleinman and unassigned nirga and galkleinman Feb 12, 2024
@nirga nirga merged commit 2140eea into main Feb 13, 2024
5 checks passed
@nirga nirga deleted the new-tests branch February 13, 2024 10:09
This was referenced Feb 13, 2024
5war00p pushed a commit to 5war00p/openllmetry-js that referenced this pull request Feb 13, 2024
@@ -27,7 +27,7 @@ import type * as vertexAiImport from "@google-cloud/vertexai";

const memoryExporter = new InMemorySpanExporter();

describe("Test Gemini GenerativeModel Instrumentation", () => {
describe.skip("Test Gemini GenerativeModel Instrumentation", () => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nirga We should revert this .skip

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@5war00p yes we need to figure out how to mock these - see #58

5war00p pushed a commit to 5war00p/openllmetry-js that referenced this pull request Feb 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants