-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: switched to mocked tests #56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
nirga
commented
Feb 12, 2024
•
edited
edited
- Langchain
- LlamaIndex
- Bedrock
- VertexAI
- Pinecone
tomer-friedman
approved these changes
Feb 13, 2024
This was referenced Feb 13, 2024
Closed
5war00p
pushed a commit
to 5war00p/openllmetry-js
that referenced
this pull request
Feb 13, 2024
5war00p
reviewed
Feb 13, 2024
@@ -27,7 +27,7 @@ import type * as vertexAiImport from "@google-cloud/vertexai"; | |||
|
|||
const memoryExporter = new InMemorySpanExporter(); | |||
|
|||
describe("Test Gemini GenerativeModel Instrumentation", () => { | |||
describe.skip("Test Gemini GenerativeModel Instrumentation", () => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nirga We should revert this .skip
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
5war00p
pushed a commit
to 5war00p/openllmetry-js
that referenced
this pull request
Feb 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.