Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Qdrant instrumentation #278

Open
wants to merge 19 commits into
base: main
Choose a base branch
from
Open

feat: Qdrant instrumentation #278

wants to merge 19 commits into from

Conversation

Anush008
Copy link

Description

This PR adds support for instrumenting @qdrant/js-client-rest.

@CLAassistant
Copy link

CLAassistant commented May 23, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

nirga
nirga reviewed May 23, 2024
View reviewed changes
Copy link
Member

@nirga nirga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for this @Anush008! Left a couple of comments

packages/instrumentation-qdrant/tests/instrumentation.test.ts Outdated Show resolved Hide resolved
packages/instrumentation-qdrant/src/instrumentation.ts Outdated Show resolved Hide resolved
packages/instrumentation-qdrant/src/instrumentation.ts Outdated Show resolved Hide resolved
@Anush008 Anush008 marked this pull request as draft May 23, 2024 14:03
@nirga
Copy link
Member

nirga commented Jun 6, 2024

@Anush008 I've run the test locally, and the problem was that you weren't awaiting the call to upsert. I've added await and it looks like I'm getting a Not Found error:

 Error: Not Found
      at Object.fun [as upsertPoints] (/Users/nirga/vecinity/openllmetry-js/node_modules/@qdrant/openapi-typescript-fetch/dist/cjs/fetcher.js:172:23)
      at processTicksAndRejections (node:internal/process/task_queues:95:5)
      at QdrantClient.upsert (/Users/nirga/vecinity/openllmetry-js/node_modules/@qdrant/js-client-rest/dist/cjs/qdrant-client.js:537:26)

Updated the PR with what I ran

@Anush008
Copy link
Author

Anush008 commented Jun 6, 2024

Thanks a lot @nirga. I'll update from here.

@Anush008 Anush008 marked this pull request as ready for review June 15, 2024 09:01
nirga
nirga reviewed Jun 15, 2024
View reviewed changes
Copy link
Member

@nirga nirga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Anush008 thanks so much! Note that build is failing (looks like you're missing a dependency?). Left a small comment as well.

packages/instrumentation-qdrant/src/instrumentation.ts
collectionName: string,
params: qdrant.Schemas["PointInsertOperations"],
) {
span.setAttribute("db.qdrant.upsert.collection_name", collectionName);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we put these constants in the semantic conventions package and reference them here?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you mean all the literals or the common ones?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All the literals. Other systems then take these and automatically build dashboards from them

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nirga nirga nirga left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Anush008 @CLAassistant @nirga