Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(watsonx instrumentation): Watsonx metric support #593

Merged
merged 10 commits into from
Mar 10, 2024
Merged

feat(watsonx instrumentation): Watsonx metric support #593

merged 10 commits into from
Mar 10, 2024

Conversation

huang-cn
Copy link
Contributor

  • I have added tests that cover my changes.
  • If adding a new instrumentation or changing an existing one, I've added screenshots from some observability platform showing the change.
  • PR name follows conventional commits format: feat(instrumentation): ... or fix(instrumentation): ....
  • (If applicable) I have updated the documentation accordingly.

fixes feature #550

  • add metrics for watsonx ai generate and streaming generate.
  • add test for metrics.
  • all tests passed in local enviroment.

@huang-cn
Copy link
Contributor Author

E2E test screenshots,
Trace:
image

Metrics:
image

@nirga nirga merged commit b3c8b5f into traceloop:main Mar 10, 2024
7 checks passed
@huang-cn huang-cn deleted the watsonx_metric_support branch March 11, 2024 01:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nirga nirga nirga approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@huang-cn @nirga