-
Notifications
You must be signed in to change notification settings - Fork 124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(instrumentation-anthropic): Support for OpenTelemetry metrics for Anthropic #764
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nirga
approved these changes
Apr 8, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @hanchchch! Great work! Looks good.
Note that you need to rebase your PR. Once you do that I can merge :)
123a5a5
to
bc48f3b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
relates to #251
Hi,
I referred a lot to #369 while working on this.
I added
token_counter
choice_counter
duration_histogram
exception_counter
metrics for all
sync
/async
completion
/messages
/streaming messages
methods.
There are a few
TODO
s, I'd appreciate it if you check it out.choice_counter
of streaming response, I just added length ofevents
bc each of it hasfinish_reason
, but I'm still not sure if it's appropriate. (opentelemetry/instrumentation/anthropic/streaming.py).exception_metric
of streaming responses. I think I should add mocks and trigger exception in the middle of yielding, but I'm just wondering if there's better way. (tests/test_completion.py)Any comments and discussions will be appreciated!
feat(instrumentation): ...
orfix(instrumentation): ...
.