-
-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(plotter, renderer): add proof-of-concept renderer #388
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## v5 #388 +/- ##
===========================================
+ Coverage 69.48% 93.53% +24.05%
===========================================
Files 42 36 -6
Lines 4516 4348 -168
Branches 446 604 +158
===========================================
+ Hits 3138 4067 +929
+ Misses 1378 281 -1097
Continue to review full report at Codecov.
|
Notes:
|
mcous
changed the title
refactor(plotter, renderer, cli): add proof-of-concept renderer and CLI
refactor(plotter, renderer): add proof-of-concept renderer
Jul 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR almost completely rewrites the v5 plotter for much better test coverage and adds an experimental proof-of-concept for the layer renderer.
Highlights
This plotter and renderer are able to deal with a majority of the Gerber fixtures in
@tracespace/fixtures
This is mostly an internal development milestone rather than anything user facing, but there's a couple helpful debugging / inspection tool in here:
pnpm dev
now serves an app with the parse tree, plot tree, and render of fixture gerbersWhat's left after this PR?