This repository has been archived by the owner on Feb 21, 2019. It is now read-only.
Feature/646 restore email reply #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…6_restore_email_reply
…6_restore_email_reply
…6_restore_email_reply
Pull Request Test Coverage Report for Build 767
💛 - Coveralls |
inkhey
changed the title
…6_restore_email_reply
buxx
suggested changes
Sep 27, 2018
| heartbeat=self.config.EMAIL_REPLY_CHECK_HEARTBEAT, | ||
| use_idle=self.config.EMAIL_REPLY_IMAP_USE_IDLE, | ||
| connection_max_lifetime=self.config.EMAIL_REPLY_CONNECTION_MAX_LIFETIME, # nopep8 | ||
| # FIXME - G.M - 2017-11-15 - proper tracim url formatting |
| @@ -125,7 +126,8 @@ def notify_content_update(self, content: Content): | |||
| self.config, | |||
| self.session, | |||
| ).notify_content_update(self._user.user_id, content.content_id) | |||
| except TypeError as e: | |||
| except Exception as e: | |||
There was a problem hiding this comment.
After discuss with @lebouquetin, change excepted class or keep.
…racim_v2 into feature/646_restore_email_reply
buxx
suggested changes
Sep 27, 2018
buxx
approved these changes
Sep 27, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related to tracim/tracim#646, tracim/tracim#839, tracim/tracim#762