Skip to content
This repository has been archived by the owner on Feb 21, 2019. It is now read-only.

Fix/958 better file name handling #90

Merged
merged 9 commits into from Oct 16, 2018

Conversation

inkhey
Copy link
Contributor

@inkhey inkhey commented Oct 15, 2018

related to tracim/tracim#958

  • remove get_label_as_file() which is a duplicate of file_name.
  • use new default file extension for content type like '.document.html' + migration script
  • add file extension in all endpoints
  • repair filename check sql query.

Todo :

@inkhey inkhey changed the title WIP: Fix/958 better file name handling Fix/958 better file name handling Oct 15, 2018
@coveralls
Copy link

coveralls commented Oct 15, 2018

Pull Request Test Coverage Report for Build 961

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 141 unchanged lines in 5 files lost coverage.
  • Overall coverage decreased (-0.0006%) to 91.742%

Files with Coverage Reduction New Missed Lines %
tracim_backend/tests/functional/test_contents.py 3 99.86%
tracim_backend/models/context_models.py 3 99.01%
tracim_backend/app_models/contents.py 3 96.52%
tracim_backend/lib/core/content.py 55 84.01%
tracim_backend/models/data.py 77 82.98%
Totals Coverage Status
Change from base Build 959: -0.0006%
Covered Lines: 16365
Relevant Lines: 17838

💛 - Coveralls

@inkhey inkhey added the backend label Oct 16, 2018
@lebouquetin lebouquetin merged commit 68e401c into develop Oct 16, 2018
@inkhey inkhey deleted the fix/958_better_file_name-handling branch October 18, 2018 07:50
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants