Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add hard error and deprecations for 1.0 #575

Merged
merged 2 commits into from
Mar 15, 2023
Merged

Add hard error and deprecations for 1.0 #575

merged 2 commits into from
Mar 15, 2023

Conversation

chriskrycho
Copy link
Collaborator

  • Make missing context a hard error in all contexts (not just assert for development).
  • Make the invalid state checks (looking up .value when not .isResolved etc.) deprecations, so people can use deprecation workflow to burn them down over time before doing the 2.0 upgrade.

And target 2.0, which will come Soon™, but is intentionally decoupled
from the 1.0 release, so that people can tackle the missing context
error first and then later tackle these changes.
@chriskrycho chriskrycho added enhancement New feature or request breaking labels Mar 15, 2023
@chriskrycho chriskrycho merged commit e5f099f into main Mar 15, 2023
@chriskrycho chriskrycho deleted the last-1.0-prep branch March 15, 2023 14:48
@chriskrycho chriskrycho mentioned this pull request Mar 15, 2023
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant