Backport context bug fix to 0.6.x #582
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chriskrycho
force-pushed
the
backport-to-0.6.x
branch
from
07d8989
to
64c6889
Compare
|
@chriskrycho won't it be a completely breaking change? |
|
Yes, for TS consumers only—but it's a bugfix breaking change (per the release notes for 1.0.1), which strictly accepts more than it did without it. |
|
ok, right- for js users second argument would be simply ignored then |
chriskrycho
force-pushed
the
backport-to-0.6.x
branch
2 times, most recently
from
df2ec0b
to
e291d31
Compare
- Remove the Ember try config we had previously removed for TS on main, for the same reason: we do *not* want to drift other dependencies when checking type tests. - Test up through 3.28 LTS, but do not try to test against 4.x, which we know this does not pass on.
chriskrycho
force-pushed
the
backport-to-0.6.x
branch
from
e291d31
to
e964577
Compare
|
GitHub is having issues with network, but everything appears to actually be passing. Merging and will release as 0.6.1. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Applies the following commits from
maintorelease-0-6-xwith the relevant modifications to account for our switch to a v2 addon: