Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare for Ember adoption #316

Open
3 of 6 tasks
chriskrycho opened this issue May 12, 2022 · 1 comment
Open
3 of 6 tasks

Prepare for Ember adoption #316

chriskrycho opened this issue May 12, 2022 · 1 comment

Comments

@chriskrycho
Copy link
Collaborator

chriskrycho commented May 12, 2022

Tracking issue for readying this package to be the "polyfill" for emberjs/rfcs#812 – we will keep this updated as that evolves!

@NullVoxPopuli
Copy link
Contributor

cross-posting from here: starbeamjs/starbeam#89

but, imo (ofc, but strong feelings), the current TrackedArray implementation needs some performance improvements before being adopted by Ember.
it's already implemented in ember-data, here: https://github.com/emberjs/data/blob/main/packages/store/src/-private/record-arrays/identifier-array.ts

Also, we probably also need proper storage primitives, because all the storage primitives (right now) greatly thrash memory and cpu compared to if the storage primitives were non-polyfilled.
(build on top of tracked requires decorator + class + instance on top of the native tracked implementation), and doing that for every tracked value is a lot.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants