Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi :)
while I was working on VZN | Reactivity I noticed several bugs related to keys tracking, so Im sharing the outcome of long investigations.
Once this will land in VZN I will also add additional tests (unless someone wants to help with that)
What has been fixed:
deleteProperty
anddefineProperty
is notifyingownKeys
change, individual desc's key accessed byhas
and theproperty
if trackedhas
is now tracking a single object desc's key instead the whole collectionset
is notifying the property only if really changed, notifying the desc's key as well the collection if new desc's key has been set