Use Ember v4 types #307
Merged
Use Ember v4 types #307
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Use latest version of `actions/setup-node`. (In the future, we should switch this to using Volta, but this is fine for now!) - Use caching provided by `actions/setup-node` instead of custom cache config. This *may* run slower, but it is almost certainly better behaved in terms of cache *busting*.
|
Huh, as far as I can tell the problem here is how the setup is reusing the cache. Hoping the version I just pushed will fix it? Update: 🎉 it did! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implicitly sets the minimum supported TS version to 4.4. However, we are not yet testing against any version, so in a future PR we need to tackle #51. This is therefore not "breaking" because TS support has been unofficial to date.