Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Node.js to 18 in CI #411

Merged
merged 1 commit into from
Oct 13, 2023
Merged

Update Node.js to 18 in CI #411

merged 1 commit into from
Oct 13, 2023

Conversation

SergeAstapov
Copy link
Collaborator

No description provided.

@SergeAstapov SergeAstapov added the dependencies Pull requests that update a dependency file label Sep 22, 2023
@chriskrycho
Copy link
Collaborator

Failure on embroider-optimized is because this still uses ember-cli-typescript to build; switching to the v2 add-on design for building TS and removing ember-cli-typescript is likely the right path forward overall, but we should also update the check in ember-cli-typescript and cut a new release there to unblock these things. Here, I think it should be safe to merge.

@SergeAstapov
Copy link
Collaborator Author

@chriskrycho As the addon itself was was updated to v2, seem like we should update test-app for typescript compilation using babel per latest ember-cli app blueprint and remove ember-cli-typescript. Thanks for that hint! I’ll update PR over the weekend or Monday

@SergeAstapov SergeAstapov merged commit de07bc4 into master Oct 13, 2023
18 checks passed
@SergeAstapov SergeAstapov deleted the bump-node-in-ci branch October 13, 2023 02:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chriskrycho chriskrycho chriskrycho approved these changes

Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@SergeAstapov @chriskrycho