-
Notifications
You must be signed in to change notification settings - Fork 108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Locale selector bit dodgy #1
Comments
Yeah, I had a bit of issues with it so I implemented a hack to get around it. I eventually refactored it out and didn't notice the issue anymore, but I think it could be very browser / race condition dependent. What browser are you using? I'll make sure to test it out using the same one. I'm using chrome / PC. I personally hate the dropdown, but I'm not a UX designer so I tried to make do with the existing look and feel elements. :) Any feedback here would be great. |
This has probably been fixed with tractorcow@5c15160 Instead of using customScript I use insertHeadTags to inject some variables into the page to be picked up by the fluent.js code that builds the menu. The script would fail if those variables weren't available when the cms menu was 'ready'. |
I was using Chrome Beta on Mac and PC. But this has fixed it. I think it would be great to have something similiar to a commercial multilanguage module for SilverStripe 3.0. http://ss-multilingualdemo.kreationsbyran.se/. Below you can find the demo login. I have used this module for 2.4 (which was free) and it was almost everything I needed in a multilanguage module. And I think fluent is giving me this feeling again apart from the CMS that can still be improved. Which I hopefully can help you with. |
…remove-deprecated-code API Remove deprecated code
The selector in the CMS seems to be a bit dodgy, sometimes it shows up and sometimes it doesnt show up.
I find it hard to reproduce this. So cant make a really better description, it just happens while browsing through the sitetree.
The text was updated successfully, but these errors were encountered: