Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct fs.fsys usage #58

Merged
merged 2 commits into from
Jan 4, 2024
Merged

Correct fs.fsys usage #58

merged 2 commits into from
Jan 4, 2024

Conversation

catilac
Copy link
Contributor

@catilac catilac commented Jan 4, 2024

I saw that there were some changes to how fs.fsys is used. But I'm new to the codebase, and still exploring the project.

@catilac catilac mentioned this pull request Jan 4, 2024
Copy link
Collaborator

@Parzival-3141 Parzival-3141 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's one last incorrect usage on line 304, but other than that looks good

@@ -301,7 +298,7 @@ func (s *Service) readdir(this js.Value, args []js.Value) any {
        go func() {                                                                
                log("readdir", path)                                               
                                                                                   
-               fi, err := fs.ReadDir(s.fsys, path)                                
+               fi, err := fs.ReadDir(s.fsys.FS, path)                             
                if err != nil {                                                    
                        cb.Invoke(jsutil.ToJSError(err))                           
                        return                                                     

kernel/fs/fs.go Outdated Show resolved Hide resolved
@Parzival-3141
Copy link
Collaborator

Thank you!

@Parzival-3141 Parzival-3141 merged commit 0d63cb2 into tractordev:main Jan 4, 2024
@catilac catilac deleted the fs_fix branch January 7, 2024 04:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants