Skip to content

Commit

Permalink
fix: add limitation length to s3 and deployment trigger (#314)
Browse files Browse the repository at this point in the history
  • Loading branch information
floross committed Nov 30, 2021
1 parent f34ccd6 commit 1108d98
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 3 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ export class DeploymentTriggerEventComponent extends AwsComponent<DeploymentTrig
rule: this.getCloudwatchEventRuleNameAsToken(),
arn: this.config.codepipelineArn,
roleArn: this.config.roleArn,
targetId: this.getResourceName('target'),
targetId: this.getResourceName('target', 64),
});
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ export class DeploymentStoreComponent extends AwsComponent<ConstructOptions> {
protected createS3Bucket() {
return new S3Bucket(this, 's3', {
provider: this.provider,
bucketPrefix: this.getResourceName(''),
bucketPrefix: this.getResourceName('', 37),
acl: 'private',
forceDestroy: true,
versioning: [{ enabled: false }],
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ export class S3Component extends AwsComponent<S3ComponentConfig> {
protected createS3Bucket() {
return new S3Bucket(this, 'bucket', {
provider: this.provider,
bucketPrefix: this.getResourceName('').replace(/_/g, '-'),
bucketPrefix: this.getResourceName('', 37).replace(/_/g, '-'),
corsRule: this.getCorsRules(),
acl: 'private',
forceDestroy: true,
Expand Down

0 comments on commit 1108d98

Please sign in to comment.