Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(terraform-service-postgres): manage pg15 backups #6

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

EdouardDem
Copy link
Member

change backup service to fekide/volumerize:1.8.2-postgres

@nx-cloud
Copy link

nx-cloud bot commented May 25, 2023

☁️ Nx Cloud Report

Attention: This version of the Nx Cloud GitHub bot will cease to function on July 1st, 2023. An organization admin can update your integration here.

CI is running/has finished running commands for commit da2cfaf. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 6 targets

Sent with 💌 from NxCloud.

@EdouardDem
Copy link
Member Author

@floross We can use pg15 now. Should we set the default postgres image tag to 15-alpine ?

@EdouardDem EdouardDem requested a review from floross May 25, 2023 04:02
@codecov
Copy link

codecov bot commented May 25, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (249d25b) 73.90% compared to head (da2cfaf) 73.90%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main       #6   +/-   ##
=======================================
  Coverage   73.90%   73.90%           
=======================================
  Files          82       82           
  Lines        1368     1368           
  Branches      252      252           
=======================================
  Hits         1011     1011           
  Misses        357      357           
Flag Coverage Δ
unittests 73.90% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@floross
Copy link
Contributor

floross commented May 25, 2023

@floross We can use pg15 now. Should we set the default postgres image tag to 15-alpine ?

We could be we need to think of the impact of the current project. If the goal is to not use terraform so much I think we should let the pg at 13 and for the new project like Fari to configure manually the version to 15. What do you think @EdouardDem ?

POSTGRES_HOST: (service) => service.getServiceDomainName('postgres'),
POSTGRES_PORT: '5432',
REMOVE_OLDER_THAN: '30D',
VOLUMERIZE_POSTGRES_DATABASE: 'api',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be Secret('POSTGRES_DB'), by default ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we set it to Secret('POSTGRES_DB') we will have to add the key POSTGRES_DB in AWS secret manager.

@EdouardDem EdouardDem closed this May 26, 2023
@EdouardDem EdouardDem deleted the backups-pg15 branch May 26, 2023 15:10
@EdouardDem EdouardDem restored the backups-pg15 branch May 26, 2023 15:11
@EdouardDem EdouardDem reopened this May 26, 2023
@EdouardDem
Copy link
Member Author

@floross Once this PR is merged, for each project, we have to change the backupsConfig in the file apps/terraform/src/configs/apps.config.ts if any.

Rename the environments (the keys, not the values) :

  • POSTGRES_DB => VOLUMERIZE_POSTGRES_DATABASE
  • POSTGRES_USER => VOLUMERIZE_POSTGRES_USERNAME
  • POSTGRES_PASSWORD => VOLUMERIZE_POSTGRES_PASSWORD
  • POSTGRES_HOST => VOLUMERIZE_POSTGRES_HOST
  • POSTGRES_PORT => VOLUMERIZE_POSTGRES_PORT

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants