New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bug fixes #156
Merged
Merged
bug fixes #156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nice!!
(via cellphone, random spelling ahead)
…On Fri, Sep 18, 2020, 6:54 PM Wenbo Tao ***@***.***> wrote:
fixed 10+ bugs found when building the wildfire demo...
- add a check in compiler that at least one view object exists;
- fixed flawed bbox calculation when jumping from a static layer;
- fixed #152 <#152>: tooltip
removal issue during pan and zoom;
- send 204 (NO_content) error response for index requests when
requesting a non-existent resource
- [SSV] add geo columns to rawTables before they are queried (which
caused no-column-found exception);
- [SSV] calculate geo coordinates before all raw rows are retrieved
(which caused failed first runs);
- [SSV] add IF EXISTS to DROP FUNCTION
- [SSV] fixed bugs with the geo map layer - wrong assumption was made
about the relationship between viewport size and top level size;
- [SSV] checked that statements are not null before closing them
(which caused null-pointer exceptions);
- [SSV] fixed the bug that longitude and latitude column names were
hardcoded
------------------------------
You can view, comment on, or merge this pull request online at:
#156
Commit Summary
- add check for no views.
- ssv geo - add geo columns to raw table before getColumnNames()
- put getGeoCoordinates before getRawRows.
- add IF EXISTS for DROP FUNCTION.
- static layer jump ancestor box bug.
- fixed bugs with ssv geo maplayer renderer
- fix tooltip removal issue.
- check if rawDbStmt is null before closing.
- send 204 error when there is error in serving index request.
- fixed the bug that longitude and latitude columns were hardcoded.
- tweak.
File Changes
- *M* back-end/src/main/java/index/Indexer.java
<https://github.com/tracyhenry/Kyrix/pull/156/files#diff-324539166c183e160b41b2273bced2a9>
(27)
- *M* back-end/src/main/java/index/SSVInMemoryIndexer.java
<https://github.com/tracyhenry/Kyrix/pull/156/files#diff-09bbd7578dd9e8968c7c0dc53698736a>
(18)
- *M* back-end/src/main/java/server/IndexHandler.java
<https://github.com/tracyhenry/Kyrix/pull/156/files#diff-d106a903ff475f71c2dce3ea81cc3bd9>
(1)
- *M* compiler/src/index.js
<https://github.com/tracyhenry/Kyrix/pull/156/files#diff-ccef8f60ccaf54b027746c74f834e8ff>
(2)
- *M* compiler/src/template-api/SSV.js
<https://github.com/tracyhenry/Kyrix/pull/156/files#diff-540e96a6b3642a84813662f321cf9107>
(16)
- *M* front-end/js/jump.js
<https://github.com/tracyhenry/Kyrix/pull/156/files#diff-da171353fc6a2023fb22d7e33fa1b082>
(6)
- *M* front-end/js/jumpAnimation.js
<https://github.com/tracyhenry/Kyrix/pull/156/files#diff-f9300a5a003613bac9febf813971cbc1>
(6)
Patch Links:
- https://github.com/tracyhenry/Kyrix/pull/156.patch
- https://github.com/tracyhenry/Kyrix/pull/156.diff
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#156>, or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AABCFYTGIRYOGHD3FSLR7D3SGPQLTANCNFSM4RSTXSOA>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixed 10+ bugs found when building the wildfire demo...
IF EXISTS
toDROP FUNCTION