[WIP] Version 3.0 #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chadicus
requested changes
Mar 6, 2018
src/Filter/DateTime.php
Outdated
| */ | ||
| public static function format(DateTimeInterface $dateTime, string $format = 'c') : string | ||
| { | ||
| if (!is_string($format) || trim($format) === '') { |
There was a problem hiding this comment.
The is_string check is useless
src/Filter/DateTime.php
Outdated
| throw new FilterException('$value is not a non-empty string'); | ||
| } | ||
|
|
||
| return new \DateTime($value, $timezone); |
There was a problem hiding this comment.
you should be consistant with the \DateTime class. You are aliasing it as DateTimeStandard but using \DateTime here.
src/Filter/DateTimeZone.php
Outdated
| * | ||
| * @return \DateTimeZone|null | ||
| * | ||
| * @throws \InvalidArgumentException Thrown if $allowNull was not a boolean value. |
There was a problem hiding this comment.
Should no longer be thrown
added 2 commits
March 6, 2018 16:02
chadicus
approved these changes
Mar 6, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.