Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add FilterOptions::RETURN_ON_NULL #93

Merged
merged 6 commits into from Jul 8, 2020
Merged

Add FilterOptions::RETURN_ON_NULL #93

merged 6 commits into from Jul 8, 2020

Conversation

chadicus
Copy link
Contributor

@chadicus chadicus commented Jul 7, 2020 •
edited

What does this PR do?

This pull request adds the returnOnNull filter option. This option will break filter chaining if a resulting filtered value is null.

Checklist

  • Pull request contains a clear definition of changes
  • Tests (either unit, integration, or acceptance) written and passing
  • Relevant documentation produced and/or updated

@chadicus chadicus requested a review from a team as a code owner July 7, 2020 22:46
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling a582745 on chadicus:fea/return-on-null into 047bc08 on traderinteractive:master.

2 similar comments
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling a582745 on chadicus:fea/return-on-null into 047bc08 on traderinteractive:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling a582745 on chadicus:fea/return-on-null into 047bc08 on traderinteractive:master.

@chadicus chadicus merged commit 3590bf1 into traderinteractive:master Jul 8, 2020
@chadicus chadicus deleted the fea/return-on-null branch July 8, 2020 01:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrisryan chrisryan chrisryan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@chadicus @coveralls @chrisryan