Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JSON filters #14

Merged
merged 4 commits into from
Feb 10, 2020
Merged

JSON filters #14

merged 4 commits into from
Feb 10, 2020

Conversation

jncarver
Copy link
Contributor

@jncarver jncarver commented Feb 6, 2020 •
edited
Loading

What does this PR do?

This pull request adds filters for validating and parsing JSON strings (see #2). The validate function will return the original value without modification, while the parse function will parse it into an array, int, float, double, bool, or null, as returned by json_decode.

Checklist

  • Pull request contains a clear definition of changes
  • Tests (either unit, integration, or acceptance) written and passing
  • Relevant documentation produced and/or updated

@jncarver jncarver requested a review from a team as a code owner February 6, 2020 17:06
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 44b8004 on jncarver:json into fa3943d on traderinteractive:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 44b8004 on jncarver:json into fa3943d on traderinteractive:master.

@coveralls
Copy link

coveralls commented Feb 6, 2020 •
edited
Loading

Coverage Status

Coverage remained the same at 100.0% when pulling 29e9c5d on jncarver:json into 5bc96ab on traderinteractive:master.

chadicus
chadicus requested changes Feb 6, 2020
View reviewed changes
Copy link
Contributor

@chadicus chadicus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good, just need to update composer.json

composer.json Outdated Show resolved Hide resolved
@jncarver jncarver merged commit 96acaf9 into traderinteractive:master Feb 10, 2020
@jncarver jncarver deleted the json branch February 10, 2020 15:22
@jncarver jncarver mentioned this pull request Feb 10, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chadicus chadicus chadicus approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jncarver @coveralls @chadicus