Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

To get zip code back by modifying database id value in netacuity #11

Merged
merged 1 commit into from
Nov 11, 2015

Conversation

krishnaramya
Copy link

This change is for returning zip code back. So updated database id as '4'.
Please peer review @chrisryan

@chrisryan
Copy link
Contributor

👍 I don't see any problems with the changes.
@chadicus @raybot can we discuss getting this merged/tagged so we can use in the api? Do we need to tag 2.0, since it changes the return values?

@chrisryan
Copy link
Contributor

some values were also removed because the request that has the extra data we needed did not include it all.

@chadicus
Copy link
Contributor

yeah, I saw that, so we will have to go to version 2

@krishnaramya
Copy link
Author

Currently I have placed "placeholders" and going to replace all those placeholders. Please don't merge this one.

It returns more values by changing database value.
@chrisryan
Copy link
Contributor

👍 @chadicus this is ready now with the correct names for all fields.

chadicus added a commit that referenced this pull request Nov 11, 2015
To get zip code back by modifying database id value in netacuity
@chadicus chadicus merged commit 3af62af into traderinteractive:master Nov 11, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants