Contributing Certora's verification rules #168
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdgeorge4153
requested review from
cryptofish7,
LouisMeMyself and
jummy123
as code owners
cryptofish7
approved these changes
Mar 9, 2022
cryptofish7
added a commit
that referenced
this pull request
Mar 9, 2022
* npm update * sanityCheck * merging latest files * stubs and methods * removed some of the template cruft * added notes from LaunchEvent discussion * munging latest files * fleshed out method specs, invariants for LaunchEvent * cleanup, added high-level rules * updating munged * draft rules list for RJS * formatting * removed template * stubs * RJ contracts update - Jan 26 * getters for userInfo added to harness * additivity and frontrunning drafted * staking rules * first run complete, some rules todo * external summaries, harness for staking total supply * more rules passing, sighash bug * initialization invariant / constructor, erc20 linking * bunch of rules fixed, added some slight harnessing * LaunchEvent report update (need review) * typo fixes * merging latest changes Feb 7 * added new invaraints and preserved, null pointer bug * some invariants passing * staking_non_trivial_rJoe timing out * changes to check * unignored certora shell scripts * sh scripts for LE * staking mostly passing, added some TODO's * closing staking * added bug * removed bug * temporary regression fixes * refactored states and added safeAssumptions * removed env from state definitions * added send_only version of scripts * message fix * fixed compilation problem * uncommented passing invariants -- which is all of them -- and modified init_TokBalCheck * sanity on of the fix * fixing sanity (still in progress) * sanity fixed, prop violations in progress * investigation * polish everything before merge * scripts finishing * staking_non_trivial_rJoe timing out * staking mostly passing, added some TODO's * closing staking * added bug * removed bug * removed munged files; recorded diffs in applyHarness.patch * added make munged to scripts * maybe properly applied harness * README tweak * removed some boilerplate * removed another diff with upstream * removed send_only from scripts Co-authored-by: Michael George <mdgeorge@cs.cornell.edu> Co-authored-by: Aleksander Kryukov <firealexkryukov@gmail.com> Co-authored-by: Sameer Arora <sameer@certora.com> Co-authored-by: Nick Armstrong <nick@certora.com> Co-authored-by: Yoav Naftali <43134169+egjlmn1@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rules have been added in the certora/ directory